Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enums #2

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Fix enums #2

merged 1 commit into from
Apr 28, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Apr 28, 2024

We're mishandling enums in all three database types here. Fix it.

…ld be specifying an inline enum or a simple string type.
@gwynne gwynne added the bug Something isn't working label Apr 28, 2024
@gwynne gwynne changed the title Postgres is case-sensitive for types; meanwhile, in other DBs we shou… Fix enums Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.72%. Comparing base (3720aa6) to head (5c25300).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   73.41%   72.72%   -0.69%     
==========================================
  Files           6        6              
  Lines         173      176       +3     
==========================================
+ Hits          127      128       +1     
- Misses         46       48       +2     
Files Coverage Δ
Sources/QueuesFluentDriver/JobModelMigrate.swift 65.00% <50.00%> (-2.57%) ⬇️

@gwynne gwynne merged commit 199bd0e into main Apr 28, 2024
11 of 12 checks passed
@gwynne gwynne deleted the fix-enum-migration branch April 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant